[PHP 8.4] fix php/doc-en#4122 (PHP 8.4: Flushing headers without a body will now succeed) #188
+23
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
o0h
changed the title
o0h
changed the title
KentarouTakeda
approved these changes
Nov 24, 2024
o0h
commented
Nov 24, 2024
| @@ -1,6 +1,6 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <!-- $Revision$ --> | |||
| <!-- EN-Revision: 91ab4f5f898023b0eed0e642e1482ac11f749d20 Maintainer: hirokawa Status: ready --> | |||
| <!-- EN-Revision: bac9d6a54fae363b3cc337bda924a76ff47e8851 Maintainer: hirokawa Status: ready --> | |||
There was a problem hiding this comment.
@KentarouTakeda (後学のために質問させてください！
ココに記載するのって、reference/outcontrol/functions/flush.xml の最終コミットかな？と思っていたのですが
php/doc-en@77ae333
ではなくて
php/doc-en@bac9d6a
であってますか？ 💡
cf: 手元で生成した revcheck.html のキャプ
There was a problem hiding this comment.
すみませんでした！はい、合ってます、つまり私の修正ミスです。
修正しました。非常に助かりました！！！
There was a problem hiding this comment.
ありがとうございます、完璧に覚えました！
次回からは自分の作業に含められそうです 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
元ネタ: php/doc-en#4122
ref: #150
該当ファイルの最新コミットが、このマージコミットになっているので
そのまま4122のFile Changedとの対応をとればOK
翻訳の内容は、 appendices/migration84/other-changes.xml を参照(尊重)しています
doc-ja/appendices/migration84/other-changes.xml
Lines 90 to 96 in c378f9b
オリジナル(en)でも、
となっているので、「殆どそのまま持ってくる」のが無難そうだと判断しました。
Refs
Preview